Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: sample lims and sample UUID #481

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Feature: sample lims and sample UUID #481

merged 10 commits into from
Dec 13, 2024

Conversation

marcomoscasgr
Copy link
Contributor

Update the annotators of Illumina and Pacbio to accept sample_uuid and sample_lims. Existing tests are updated accordingly.

Requires perl-irods-wrap#329

@marcomoscasgr marcomoscasgr self-assigned this Dec 2, 2024
@marcomoscasgr marcomoscasgr marked this pull request as ready for review December 10, 2024 15:49
@marcomoscasgr marcomoscasgr marked this pull request as draft December 10, 2024 18:44
@marcomoscasgr marcomoscasgr requested a review from mgcam December 11, 2024 12:37
@marcomoscasgr marcomoscasgr marked this pull request as ready for review December 11, 2024 12:41
mgcam
mgcam approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@mgcam mgcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was tested against data in dev iRODS and dev mlwh for single sample data and tag0 (Illumina) and unassigned (PacBio) data.

@mgcam mgcam merged commit d900d57 into wtsi-npg:devel Dec 13, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgcam mgcam mgcam approved these changes

Assignees

@marcomoscasgr marcomoscasgr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcomoscasgr @mgcam